Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a constructor for a new transmission and client or make the zero value work better #49

Open
maplebed opened this issue Apr 17, 2019 · 0 comments
Labels
status: help wanted Seeking more eyes and hands. type: enhancement

Comments

@maplebed
Copy link
Contributor

It's easy to leave off a config value when creating a client or transmission Sender struct by hand and the result will be undesirable. For example, forget to specify BatchTimeout and an idle libhoney will never send events until they reach the max batch size.

This can be fixed by being vigilant about always setting all the important members of the struct, or it can be fixed by using sane defaults for members that are not overridden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted Seeking more eyes and hands. type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants