Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider undeprecating Config.Transport or providing a better API for constructing a default transmission.Sender #121

Open
alecb-stripe opened this issue Apr 23, 2021 · 1 comment
Open

Consider undeprecating Config.Transport or providing a better API for constructing a default transmission.Sender #121

alecb-stripe opened this issue Apr 23, 2021 · 1 comment
Labels
status: help wanted Seeking more eyes and hands. type: enhancement

Comments

@alecb-stripe
Copy link

alecb-stripe commented Apr 23, 2021 •
edited
Loading

As-is (unless I'm missing something), it's non-trivial to override just the transport for connecting to honeycomb (without using the deprecated Config.Transport field).

There's no way to construct a sane "default" transmission.Honeycomb instance, and constructing one manually requires referencing a bunch of constants myself, and potentially double-specifying things like the logger or statsd client I want to use.
@alecb-stripe alecb-stripe changed the title Consider undeprecating Config.Transport or providing a better API for constructing a default transmition.Sender Consider undeprecating Config.Transport or providing a better API for constructing a default transmission.Sender Apr 23, 2021
@MikeGoldsmith
Copy link
Contributor

Feels similar to #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted Seeking more eyes and hands. type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeGoldsmith @alecb-stripe