feat: support classic ingest keys

[brookesargent]

Which problem is this PR solving?

• We've released Ingest Keys, but need to update the key detection logic to allow Ingest Keys to be used to send data to Classic environments.

Short description of the changes

• Updated the IsClassic lambda expression to a function with the new Regex logic
• Updated the Dataset test to include cases for the new key format**

** Note: For most other libhoneys we have made this IsClassic function public. However, since .NET does not have a beeline, it seemed like it would be best to leave this as a private method. Since it is private, it also becomes harder to write a unit test for, which is why I am testing it through DefaultDataset. Let me know if there's a preferred approach to testing private methods through reflection or something like that.

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1206670034694150

[cewkrupa]

Testing this change the same way the isClassic check was being tested before makes sense if we're keeping it a private method! I could still be convinced to make it a public method, but this seems perfectly fine to me

[MikeGoldsmith]

The new function looks good. I've added a commit to make the IsClassic function internal and then exposed it to the test project using the InternalsVisbleTo directive. This means the function isn't public for consumers to see / use and can be tested.

If you could add some tests IsClassic like we have for the other libhoney's, that would be great.

[brookesargent]

The new function looks good. I've added a commit to make the IsClassic function internal and then exposed it to the test project using the InternalsVisbleTo directive. This means the function isn't public for consumers to see / use and can be tested.

If you could add some tests IsClassic like we have for the other libhoney's, that would be great.

Thanks for your help, Mike! Just pushed up some direct tests for IsClassic

[MikeGoldsmith]

Looks good 👍🏻

[MikeGoldsmith]

Looks good 👍🏻

PS I noticed one more small suggestion for checking the write key is not null / empty.