Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build example as part of CI test phase #65

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

MikeGoldsmith
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith commented May 12, 2022

Which problem is this PR solving?

We have a local example that demonstrates some expected usage patterns but is not tied directly to what it's the main projects. This change updates the CI build phase to also build the example app to ensure we do not accidentally break APIs.

Short description of the changes

  • Update CI test step to build the example app

image

@MikeGoldsmith MikeGoldsmith added version: no bump A PR with maintenance or doc changes that aren't included in a release. type: maintenance The necessary chores to keep the dust off. labels May 12, 2022
@MikeGoldsmith MikeGoldsmith requested a review from a team May 12, 2022 13:08
@MikeGoldsmith MikeGoldsmith self-assigned this May 12, 2022
@MikeGoldsmith MikeGoldsmith merged commit 6285a8f into main May 13, 2022
@MikeGoldsmith MikeGoldsmith deleted the mike/build-example-ci branch May 13, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example app is checked in CI
2 participants