generated from honeycombio/.github
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Add s/m/l screen size resource attribute (#129)
## Which problem is this PR solving? Adds a resource attribute that classifies screen sizes into `small`, `medium` and `large`. ## Short description of the changes - Adds `screen.size`: `small` | `medium` | `large` - `small` is less than 768px - `medium` is between 768px and 1024px - `large` is greater than 1024px All of these were based on common media query sizes. ## How to verify that this has the expected result Run the app and see the `screen.size` attribute added to every span. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1207174650502127 --------- Co-authored-by: Mustafa Haddara <mustafaayhaddara@yahoo.com>
- Loading branch information
1 parent
e46248c
commit e810125
Showing
3 changed files
with
33 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters