feat: support classic ingest keys #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookesargent
added
merge at will
jharley
approved these changes
Mar 5, 2024
JamieDanielson
approved these changes
Mar 6, 2024
| @@ -98,7 +99,13 @@ def is_classic(apikey: str) -> bool: | |||
| Returns: | |||
| bool: true if the api key is a classic key, false if not | |||
| """ | |||
| return apikey and len(apikey) == 32 | |||
| if not apikey: | |||
There was a problem hiding this comment.
fancy! Can we update the comment to mention the new logic for ingest keys?
It's also used in setting the traces headers but it's probably still fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We've released Ingest Keys, but need to update the key detection logic to allow Ingest Keys to be used to send data to Classic environments.
Short description of the changes
How to verify that this has the expected result
It should be possible to use an ingest key pointed to a classic environment after this change. Please note that the ability to create ingest keys in classic environments isn't yet publicly available (since we need to update this library and others to understand classic ingest keys).