Make the TRACE_ID unique across repos and re-runs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the repo name and a random suffix to TRACE_ID. Otherwise this ID would not be unique across repositories and re-runs (which preserve the RUN_ID, see https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#default-environment-variables).
|
Hi @DavidS, thanks for all the contributions! The changes look fine but I haven't had time yet to check them out in detail. I should be able to do that tomorrow or Wednesday at the latest. |
no worries - the entire team over here is about to head into vacation for two weeks. This ain't a hurry. Merry Christmas and I hope you get some good down time over the holidays! Thanks for all the time and work you put into this, really made a difference for us. |
yvrhdn
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the repo name and a random suffix to TRACE_ID. Otherwise
this ID would not be unique across repositories and re-runs (which preserve
the RUN_ID, see https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#default-environment-variables).
This fixes #16.