Remove plural from API secret #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit confusing and inconsistent. In particular, in the [baseline buildevent library README](https://github.com/honeycombio/buildevents#environment-variables), it is suggested to use `BUILDEVENT_APIKEY`. And that is consistent with the [CircleCI orb docs](https://github.com/honeycombio/buildevents-orb#overview). If people are going between the two docs it is very possible that they will introduce a hard to identify bug. NOTE: this requires updating of the new guide. If this PR is merged, I will take that on immediately following.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit confusing and inconsistent. In particular, in the baseline buildevent library README, it is suggested to use
BUILDEVENT_APIKEY. And that is consistent with the CircleCI orb docs.If people are going between the two docs it is very possible that they will introduce a hard to identify bug.
NOTE: this requires updating of the new guide. If this PR is merged, I will take that on immediately following.