[trace] Fix race between CreateAsyncChild and span.Send #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateChild
adds a new span to the current span's list of children.CreateAsyncChild
callsCreateChild
, then sets the isAsync bool on the span. This can lead to a race caused by simultaneous read of the child span'sisAsync
bool bySend
as it's being written byCreateAsyncChild
. To fix this, I refactored the code a bit to allow us to setisAsync
before the span is added to the list of child spans.This doesn't seem to be the same race reported in #38 but it should be fixed either way.