[trace] Fix race between CreateAsyncChild and span.Send #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CreateChild` adds a new span to the current span's list of children. `CreateAsyncChild` calls `CreateChild`, then sets the isAsync bool on the span. This can lead to a race caused by simultaneous read of the child span's `isAsync` bool by `Send` as it's being written by `CreateAsyncChild`. To fix this, I refactored the code a bit to allow us to set `isAsync` before the span is added to the list of child spans. This doesn't seem to be the same race reported in #38 but it should be fixed either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateChildadds a new span to the current span's list of children.CreateAsyncChildcallsCreateChild, then sets the isAsync bool on the span. This can lead to a race caused by simultaneous read of the child span'sisAsyncbool bySendas it's being written byCreateAsyncChild. To fix this, I refactored the code a bit to allow us to setisAsyncbefore the span is added to the list of child spans.This doesn't seem to be the same race reported in #38 but it should be fixed either way.