Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-define capacities for rollups and TLFs #353

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

lizthegrey
Copy link
Member

@lizthegrey lizthegrey commented Oct 12, 2022

Which problem is this PR solving?

Short description of the changes

  • define the map capacity in advance before returning it.

a subsequent follow-up might be allowing passing a map in its entirety to github.com/honeycombio/libhoney-go.(*Event).AddField so that the map entries do not need to be added one at a time when merging the maps together.

Or, better yet, golang/go#56182 could prevent this problem by giving us a more sensible API for mass additions to a map.

@vreynolds vreynolds added the status: oncall Flagged for awareness from Honeycomb Telemetry Oncall label Oct 14, 2022
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizthegrey 👍🏻

@MikeGoldsmith MikeGoldsmith merged commit 99bcf6a into main Oct 17, 2022
@MikeGoldsmith MikeGoldsmith deleted the lizf.map-capacities branch October 17, 2022 13:53
@kentquirk kentquirk added version: bump patch A PR with release-worthy changes and is backwards-compatible. and removed status: oncall Flagged for awareness from Honeycomb Telemetry Oncall labels Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants