[hnygrpc] add a human readable version of the grpc status code to auto instrumentation #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o instrumentation
MikeGoldsmith
approved these changes
Nov 8, 2021
MikeGoldsmith
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When looking at traffic instrumented with
hnygrpc, I break down byhandler.methodandresponse.grpc_status_code. This is all well and good, but what I get back for the status code is 0,12, 16.While HTTP has been around long enough that many folks know what 200 and 404 mean, I don't have the same drilled-in understanding of what grpc codes 12 and 16 are. (turns out,
UnimplementedandUnauthenticated. reference)Short description of the changes
To aid the people using this instrumentation, this change augments
response.grpc_status_codewithresponse.grpc_status_messagethat contains the.String()version of the code, so people can seeUnimplementednext to12when looking at their responses.