Remove dependency on opentelemetry-go #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move necessary types and parsing logic from OpenTelemetry propagators and tracestate implementation into beeline so we can break the dependency on the OTel packages.
paulosman
force-pushed
the
paul.remove_otel_dependency
branch
from
126bd33
to
e42fdbe
Compare
paulosman
added
status: review needed
vreynolds
reviewed
Aug 26, 2021
| @@ -285,9 +283,10 @@ func TestB3TraceContext(t *testing.T) { | |||
| ParentID: "b7ad6b7169203331", | |||
| } | |||
| ctx, headers := MarshalB3TraceContext(context.Background(), prop) | |||
| assert.Equal(t, 4, len(headers), "B3 Trace Context should have three headers") | |||
There was a problem hiding this comment.
The text says "three" but the test used to assert 4?
There was a problem hiding this comment.
@vreynolds so funny enough, this was a bug. Because of this section of code in b3.go:
for _, key := range propagator.Fields() {
headerMap[key] = supp.Get(key)
}
We were always setting x-b3-flags with no value. This is technically incorrect, so we're fixing the bug in this PR. I can't think of any functionality that would depend on this bug, since the header value doesn't exist.
vreynolds
reviewed
Aug 26, 2021
vreynolds
approved these changes
Aug 27, 2021
bdarfler
removed
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The beeline currently has dependencies on multiple OpenTelemetry packages. These were introduced to provide support for parsing and generating trace context headers using W3C Trace Context and B3 header formats. This PR breaks that dependency by adding the following types (taken from opentelemetry-go) to the propagation package in the beeline:
TraceFlags- also exposed inpropagation.PropagationContextIsSampled() boolWithSampled(sampled bool) TraceFlagsMarshalJSON() ([]byte, error)String() stringFlagsSampled- a constant used in the TraceFlags bit-maskAdditionally, the parsing and generating logic for B3 headers has been taken from the OTel B3 propagator.