Backup demo styling reference #65
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You ask me for review and dont give me detail what the change is for? |
BowTiedHeron
force-pushed
the
final-style-fixes
branch
from
a09370d to
c5c3253
Compare
I thought the commit messages and the title made it obvious enough. Added more details in the PR message. |
BowTiedHeron
force-pushed
the
final-style-fixes
branch
from
c5c3253 to
4071333
Compare
|
I will convert this branch to smaller PRs into main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some temporary changes to styling so we are able to ship a version without false data and some quick fixes:
Commented out calculations:
liquidation price set to N/A -> until calculation works correctly
comment out ltv sliders -> until it works correctly
comment out health level for now -> until it works correctly
Changed input fields
remove scroll from all inputs -> there was a scrollbar present in input fields, this removes it
allow input take undefined/empty value -> to avoid having to manually remove the 0's in the input fields
Styling:
comment out isDisabled prop for gray infos -> need to build in the right logic for this, for now just removed it
set max slider point to 50% -> until max value logic has been verified