Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-homewizard-power-consumption #697

Closed
jasper-seinhorst opened this issue Mar 3, 2024 · 6 comments
Closed

homebridge-homewizard-power-consumption #697

jasper-seinhorst opened this issue Mar 3, 2024 · 6 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@jasper-seinhorst
Copy link

Link To GitHub Repo

https://github.com/jasper-seinhorst/homebridge-homewizard-power-consumption

Link To NPM Package

https://www.npmjs.com/package/homebridge-homewizard-power-consumption

Plugin Icon (Optional)

No response

@jasper-seinhorst jasper-seinhorst added the pending the label given to a new verification/icon request label Mar 3, 2024
Copy link

github-actions bot commented Mar 3, 2024

✅ Pre-checks completed successfully.

@bwp91
Copy link
Contributor

bwp91 commented Mar 17, 2024

Hi @jasper-seinhorst

Is your plugin in any way related to https://github.com/jvandenaardweg/homebridge-homewizard-energy-socket ?

Or are they different purposes?

@bwp91 bwp91 added awaiting-user-reply use after review has started - awaiting user to reply to a comment and removed pending the label given to a new verification/icon request labels Mar 17, 2024
@jasper-seinhorst
Copy link
Author

Hi @bwp91

Thank you for taking the time to validate my plugin 😀

The two plugins are for different products. Homewizard offers products to read your power usage, but also has a webshop for green products. The other plugin is a plugin for one of their products; the smart sockets.

My / the new plugin is for Homewizards main product; insight in the overall power consumption at home and the power return if you have solar panels.

Long stort short, same manufacturer, but very different products and thus different plugins.

Cheers! Jasper

@bwp91 bwp91 added currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes and removed awaiting-user-reply use after review has started - awaiting user to reply to a comment labels Mar 17, 2024
Copy link

github-actions bot commented Mar 17, 2024

  • General
    • The plugin must be of type dynamic platform.
    • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
  • Repo
    • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
    • A GitHub release should be created for every new version of your plugin, with release notes.
  • Environment
    • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
    • The plugin must successfully install and not start unless it is configured.
    • The plugin must not execute post-install scripts that modify the users' system in any way.
    • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • Codebase
    • The plugin must implement the Homebridge Plugin Settings GUI.
    • The plugin must not contain any analytics or calls that enable you to track the user.
    • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
    • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.



Comment /check to run checks again.

@bwp91 bwp91 added verified use when a plugin meets the criteria - adds the verified badge text and removed currently-reviewing use for starting a review - adds a comment with the verification list with empty checkboxes labels Mar 17, 2024
Copy link

Congratulations! Your plugin has been verified.

You can now add one of the Verified by Homebridge badges to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

verified-by-homebridge

[![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

@bwp91
Copy link
Contributor

bwp91 commented Mar 17, 2024

Nice one thank you!

@bwp91 bwp91 closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

2 participants