-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
homebridge-ecoforest-thermostat #616
Comments
✅ Pre-checks completed successfully. |
Comment
|
Hi @CyberMrProper we recently added a criteria that plugins must be dynamic platform based, rather than accessory type. A brief look at the plugin and it seems like this really wouldn't suit a platform type right? I mean, there is no login into an external cloud provider, the device is found and discovered locally? |
And I assume that most users would only have one of these devices anyway (rather than multiple)? |
It is a local/device with its own IP, and the device is a pellet stove. For now this is a single device, not sure if this brand eventually will launch additional devices. So for now, keeping it as a single accessory makes sense to me. |
With a config of this: "accessories": [
{
"name": "Example",
"apiroute": "1.1.1.1",
"username": "b",
"temperatureColdTolerance": 0.5,
"temperatureHotTolerance": 0.5,
"minPowerLevel": 1,
"maxPowerLevel": 9,
"pullInterval": 10000,
"accessory": "EcoforestThermostat"
}
], An unhandled error is thrown:
Please remember that the validation in the config schema file is not enforced on the user, so they can end up with a config like mine (i did this via the plugin settings UI) so all formations of a config need to be accounted for |
You are right! thanks for pointing it out, adding the fix in v1.1.6 |
Nice, I have tried various weird combinations of other configs and I cannot get it to crash so thanks for fixing that one! The other things I would maybe suggest, but not necessary for verification:
|
Congratulations! Your plugin has been verified. You can now add one of the Verified by Homebridge badges to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! Thank you for your contribution to the Homebridge Community. |
Thank you!! |
Icon added too :) |
Link To GitHub Repo
https://github.com/CyberMrProper/homebridge-ecoforest-thermostat/
Link To NPM Package
https://www.npmjs.com/package/homebridge-ecoforest-thermostat
Plugin Icon (Optional)
The text was updated successfully, but these errors were encountered: