Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart server with confirmation. Username next to Logout. #1658

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 8, 2023

  • Added confirmation (do you want to restart the server?) After pressing the power icon directly on the bar (as in the menu).
  • Added username next to logout:
Zrzut ekranu 2023-11-8 o 15 07 52
  • Minor corrections in pl language

@bwp91
Copy link
Contributor

bwp91 commented Nov 8, 2023

Sorry Im gonna use this PR to ask a couple of different things!

  1. Could this menu in desktop view be moved so the top lines up with the botton of the main top menu? (ignore the restart tooltip!)

Screenshot 2023-11-08 at 18 53 31

  1. i wonder if these dropdowns need a slightly darker background colour to make it clearer amongst the other things behind it?
    Screenshot 2023-11-08 at 18 53 52

@mkz212 mkz212 changed the title Added confirmation modal - restart server Restart server with confirmation. Username next to Logout. Nov 8, 2023
@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

Yes. I will make PR.

Like this (menu position and dropdown color)?:

Zrzut ekranu 2023-11-8 o 20 19 53

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

@bwp91 Ok, I just created two PR with this.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

What do you think about removing the underlining of links?

Zrzut ekranu 2023-11-8 o 20 44 40

Instead of the current one:

Zrzut ekranu 2023-11-8 o 20 45 34

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 8, 2023

And what do You think about this PR?

  • confirmation modal to restart sever, in dropdown menu already is so it could be also after click on power icon in navbar.

  • username next to Logout in dropdown menu, E.G.: Logout - admin

@donavanbecker donavanbecker enabled auto-merge (squash) November 9, 2023 03:44
@donavanbecker donavanbecker merged commit 9ba9675 into homebridge:beta-4.52.2 Nov 9, 2023
13 checks passed
@donavanbecker
Copy link
Contributor

@mkz212, Big issue with dark mode!

Screenshot 2023-11-08 at 10 27 14 PM

@donavanbecker
Copy link
Contributor

Same with Light Mode Screenshot 2023-11-08 at 10 27 56 PM

donavanbecker added a commit that referenced this pull request Nov 9, 2023
@donavanbecker
Copy link
Contributor

I have reverted these changes So please open a new PR with changes.

@mkz212 mkz212 deleted the patch-12 branch November 9, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants