Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default widget layout #1641

Merged
merged 36 commits into from
Nov 7, 2023

Conversation

mkz212
Copy link
Contributor

@mkz212 mkz212 commented Nov 7, 2023

My last approach to default look suggestion.

Zrzut ekranu 2023-11-7 o 09 31 00

@bwp91 bwp91 mentioned this pull request Nov 7, 2023
@bwp91
Copy link
Contributor

bwp91 commented Nov 7, 2023

Don't forget to bring that scan to add to homekit language change here, I like the idea of the text being shortened, but I will leave this PR for @donavanbecker as I know he has been putting some work into screenshots for widget layouts 👍

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

I changed the text in all language versions (using Google translate).

@donavanbecker donavanbecker enabled auto-merge (squash) November 7, 2023 12:10
@donavanbecker donavanbecker merged commit b5d6128 into homebridge:beta-4.52.2 Nov 7, 2023
12 of 13 checks passed
@donavanbecker
Copy link
Contributor

Looks like something got messed up with the layout, I hit reset layout and got this:

Screenshot 2023-11-07 at 11 01 43 AM

@donavanbecker
Copy link
Contributor

I will push a fix and see if it resolves it.

donavanbecker added a commit that referenced this pull request Nov 7, 2023
@grzegorz914
Copy link
Contributor

Also on iPad portrait and landscape mode cut the widget.
IMG_0902
IMG_0901

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@donavanbecker I just updated code. Can You try? (Child Bridge Widget x position should be 15, not 16).

@donavanbecker
Copy link
Contributor

@grzegorz914 does beta.25 fix it?

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

I think that Homebridge widget should be scrollable (like System info widget).

@grzegorz914
Copy link
Contributor

@donavanbecker no, the problem still exist with b.25

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@donavanbecker Child Bridge Widget x position should be 15, not 16. And there is no "Homebridge" word , only version.

@donavanbecker
Copy link
Contributor

okay, I updated what you had @mkz212. If that doesn't work. I am going to revert back to what I had and see if it resolves it.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

also need to add to /ui/src/scss/themes-dark.scss :

.dropdown-item, .dropdown-item:hover {
   color: #eeeeee;
}

to fix this:
Zrzut ekranu 2023-11-7 o 19 19 35

@donavanbecker
Copy link
Contributor

that worked @mkz212.

@grzegorz914 beta.26. How is that for you?

@donavanbecker
Copy link
Contributor

also need to add to /ui/src/scss/themes-dark.scss :

.dropdown-item, .dropdown-item:hover {
   color: #eeeeee;
}

to fix this: Zrzut ekranu 2023-11-7 o 19 19 35

I think you meant to put this in a different PR right?

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

  • beta 26 fix layout.

  • Still no Homebridge word next to version in Homebridge widget.

Zrzut ekranu 2023-11-7 o 19 29 18
  • also need to add to /ui/src/scss/themes-dark.scss :
.dropdown-item, .dropdown-item:hover {
   color: #eeeeee;
}

@grzegorz914
Copy link
Contributor

@donavanbecker b.26 nothing changed but I can rearrange it and adapted to the screen. looks like the size is only dynamic in x size and for y size is static.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@donavanbecker I wouldn't want to mess up too much now. Could you add this code?

to /ui/src/scss/themes-dark.scss :

.dropdown-item, .dropdown-item:hover {
   color: #eeeeee;
}

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@grzegorz914 I think that problem is because this widget is not scroled like the widget system info. In the last stable version, with such a layout as you present it also does not display correctly for me - the widget is simply too narrow for this.

@donavanbecker
Copy link
Contributor

@donavanbecker I wouldn't want to mess up too much now. Could you add this code?

to /ui/src/scss/themes-dark.scss :

.dropdown-item, .dropdown-item:hover {
   color: #eeeeee;
}

added for next beta.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@donavanbecker

  • Maybe simple solution is change text: "Uruchomiony na porcie: 55555" to "Port: 55555". ?
  • Still no Homebridge word next to version. Can You fix this?

@bwp91
Copy link
Contributor

bwp91 commented Nov 7, 2023

do we need the word homebridge next to the version? the widget title is homebridge, is it not obvious?
also with longer beta version names, having homebridge there too might push that column to be quite wide

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@bwp91 I thought it was a mistake. Ok. But I would change the text from: "Uruchomiony na porcie: 55555" to "Port: 55555".

Zrzut ekranu 2023-11-7 o 19 50 35

@donavanbecker
Copy link
Contributor

donavanbecker commented Nov 7, 2023

@mkz212, you have an option to hide that port also.

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

And this can fix display of item:

Zrzut ekranu 2023-11-7 o 19 53 55

Every item need to have mr-5 pr-5

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@mkz212, you have an option to hide that port also.

Yes, I know, But I think this text is too long and looks better just: Port: 55555

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

@bwp91 @donavanbecker

beta27 looks great. Only two changes in Homebridge widget:

  • change text from Uruchomiony na porcie (Running on port) to simply Port: E.G. Port: 12345.
  • to every item class add: mr-5 pr-5
Zrzut ekranu 2023-11-7 o 19 53 55

So it will change this:
Zrzut ekranu 2023-11-7 o 20 08 44

to this:
Zrzut ekranu 2023-11-7 o 20 09 46

@donavanbecker
Copy link
Contributor

@mkz212, open a PR with these changes and I will merge

@mkz212
Copy link
Contributor Author

mkz212 commented Nov 7, 2023

beta 30 looks fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants