-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure systemd-resolved has mDNS enabled #982
Ensure systemd-resolved has mDNS enabled #982
Conversation
cc: @Supereg |
Pull Request Test Coverage Report for Build 3374361088
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3417210565
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for dealing with this so fast 🚀
Looks good to me. Only had two small comments.
8d0b144
to
f5e3405
Compare
Just released |
f77a1d3
to
e9e8ef5
Compare
Co-authored-by: Andi <mail@anderl-bauer.de>
Okay, this should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot 🚀
Co-authored-by: Supereg <mail@anderl-bauer.de>
♻️ Current situation
Per #980, the systemd-resolved advertiser reports that it's available even if systemd-resolved has mDNS disabled.
💡 Proposed solution
Check that mDNS is enabled in systemd-resolved before reporting that it is available as an advertiser.
⚙️ Release Notes
--
Testing
--
Reviewer Nudging
--
Notes
This also adds a note to the error message when advertisements fail that there may be a permissions issue and the user should check the wiki for more details. The info to be added to the wiki will be posted in #980.