Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure systemd-resolved has mDNS enabled #982

Merged

Conversation

elyscape
Copy link
Contributor

@elyscape elyscape commented Nov 2, 2022

♻️ Current situation

Per #980, the systemd-resolved advertiser reports that it's available even if systemd-resolved has mDNS disabled.

💡 Proposed solution

Check that mDNS is enabled in systemd-resolved before reporting that it is available as an advertiser.

⚙️ Release Notes

--

Testing

--

Reviewer Nudging

--

Notes

This also adds a note to the error message when advertisements fail that there may be a permissions issue and the user should check the wiki for more details. The info to be added to the wiki will be posted in #980.

@elyscape
Copy link
Contributor Author

elyscape commented Nov 2, 2022

cc: @Supereg

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3374361088

  • 2 of 14 (14.29%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 51.868%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/Advertiser.ts 2 14 14.29%
Files with Coverage Reduction New Missed Lines %
src/lib/Advertiser.ts 1 40.0%
Totals Coverage Status
Change from base Build 3370777112: -0.05%
Covered Lines: 5821
Relevant Lines: 10259

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 2, 2022

Pull Request Test Coverage Report for Build 3417210565

  • 6 of 31 (19.35%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 51.815%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/Advertiser.ts 6 31 19.35%
Files with Coverage Reduction New Missed Lines %
src/lib/Advertiser.ts 1 38.44%
Totals Coverage Status
Change from base Build 3370777112: -0.1%
Covered Lines: 5824
Relevant Lines: 10271

💛 - Coveralls

@Supereg Supereg self-requested a review November 2, 2022 03:06
Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for dealing with this so fast 🚀

Looks good to me. Only had two small comments.

src/lib/Advertiser.ts Outdated Show resolved Hide resolved
src/lib/Advertiser.ts Show resolved Hide resolved
@Supereg Supereg added the fix label Nov 2, 2022
src/lib/Advertiser.ts Outdated Show resolved Hide resolved
@Supereg
Copy link
Member

Supereg commented Nov 3, 2022

Just released @homebridge/dbus-native v0.5.0 with the respective change implemented in homebridge/dbus-native#2

src/lib/Advertiser.ts Outdated Show resolved Hide resolved
@elyscape elyscape force-pushed the resolved-check-mdns-support branch from f77a1d3 to e9e8ef5 Compare November 8, 2022 07:16
Co-authored-by: Andi <mail@anderl-bauer.de>
@elyscape
Copy link
Contributor Author

elyscape commented Nov 8, 2022

Okay, this should be good to go now.

Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🚀

@Supereg Supereg merged commit c53c9a2 into homebridge:beta-0.11.0 Nov 8, 2022
@elyscape elyscape deleted the resolved-check-mdns-support branch November 8, 2022 22:34
Supereg added a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Supereg <mail@anderl-bauer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants