Improve test coverage #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3468588397
💛 - Coveralls |
Supereg
force-pushed
the
feature/test-coverage-improvements
branch
from
f7a3062 to
5d98a5d
Compare
Supereg
force-pushed
the
feature/test-coverage-improvements
branch
2 times, most recently
from
9193165 to
0faafca
Compare
Its internal API. Seems to expose differing behavior in previous versions of node
* Create HAPClient abstraction * Last few tests
Supereg
force-pushed
the
feature/test-coverage-improvements
branch
from
d941bd4 to
bfb665d
Compare
Supereg
added a commit
that referenced
this pull request
Nov 18, 2022
* Add tlv test cases * Add eventedhttp test cases * Fix cyclic imports! Add small HAPServer test * Add basic HAPServer negative test cases * Add test case to verify we are sending out correct event trigger options (see #976) * /pair-setup and pair-verify test cases * Test that encryption keys work after pair-verify step * Add characteristic WRITE tests * Add RecordingManagement tests * Adding Accessory pairing tests * Fix spelling and improve typing of addService * add tests for handleAccessories * Simple characteristic read test * Add coverage badge * Adding characteristic write tests * Add controller tests, add bind option tests, add characteristic warning tests * Todo cleanup and write response tests * Add more detailed hapCrypto layerEncrypt and layerDecrypt tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently, a lot of parts of the HAP-NodeJS library are lacking test cases and consequentially the test coverage of the project is pretty low. This reduces our ability to catch regressions when doing changes to the code base.
💡 Proposed solution
This PR tries to improve the situation adding several test cases.
⚙️ Release Notes
➕ Additional Information
This PR contains also slight adjustments to the code itself where it made sense or where bugs were uncovered while wiring the tests.
The PR also introduces several deprecation warnings.
The following was changed:
includeTypeinstead of the characteristic typeAccessory.addServiceEventedHTTPServerand open timeout handles.Testing
Well, we added test cases for a bunch of components.
Reviewer Nudging
--