-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Support for GE Opal Ice Maker #13
Closed
Closed
+1,322
−893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a064efa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Support missing for Opal Ice Maker
💡 Proposed solution
Introduces nightlight support and power toggle for Opal Ice Maker
⚙️ Release Notes
Introduces nightlight support and power toggle for Opal Ice Maker
➕ Additional Information
It seems I had to clone the repo into nvm (global) node_modules and replace the version tags in package*.json to set up a dev environment
Testing
BDD, watching ice getting made now. :)
Reviewer Nudging
I originally branched off of
v0.2.0-beta.13
tag, since i'm comparing aganist an older branch, you could just observe the changes aganist the beta tag, see the last two commits from me or find the relevant changes in:src/devices/icemaker.ts
src/platform.ts
Basically, if you just search for
SmartHQIceMaker
it should show you the relevant changes, also the ErdOIM
types insrc/settings.ts