Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Support for GE Opal Ice Maker #13

Closed
wants to merge 20 commits into from

Conversation

jamesh48
Copy link

@jamesh48 jamesh48 commented Feb 23, 2025

♻️ Current situation

Support missing for Opal Ice Maker

💡 Proposed solution

Introduces nightlight support and power toggle for Opal Ice Maker

⚙️ Release Notes

Introduces nightlight support and power toggle for Opal Ice Maker

➕ Additional Information

It seems I had to clone the repo into nvm (global) node_modules and replace the version tags in package*.json to set up a dev environment

Testing

BDD, watching ice getting made now. :)

Reviewer Nudging

I originally branched off of v0.2.0-beta.13 tag, since i'm comparing aganist an older branch, you could just observe the changes aganist the beta tag, see the last two commits from me or find the relevant changes in:

  • src/devices/icemaker.ts
  • src/platform.ts

Basically, if you just search for SmartHQIceMaker it should show you the relevant changes, also the Erd OIM types in

  • src/settings.ts
  // Ice Maker
  OIM_STATUS: "0x9100",
  OIM_LIGHT_LEVEL: "0x9101",
  OIM_UNKNOWN9102: "0x9102",
  OIM_FILTER_STATUS: "0x9104",
  OIM_NEEDS_DESCALING: "0x9106",
  OIM_POWER: "0x9107",
  OIM_PRODUCTION: "0x9108",

@jamesh48 jamesh48 changed the title Support for GE Opal Ice Maker Basic Support for GE Opal Ice Maker Feb 23, 2025
@jamesh48 jamesh48 changed the base branch from latest to beta-0.2.0 February 23, 2025 08:52
@jamesh48 jamesh48 closed this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants