Eliminate possible addon data race condition during update #4619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently addon update has a possible race condition with the global addon data. This can be triggered as follows:
In this situation Supervisor ends up pulling one image but telling the addon a completely different image is in use. And then promptly removing the image it just pulled as it believes it is stale.
The unit test reproduces this race condition by simulating with asyncio events prior to the code change. It is not reproducible afterwards. I believe this change to be the solution to #4610 . Although we can't be certain as we have no logs or steps to reproduce clearly showing what is occurring on these systems. Still it seems likely as the steps I outlined above would result in that exact error.
Type of change
Additional information
Checklist
black --fast supervisor tests
)If API endpoints of add-on configuration are added/changed: