Make platform setup a coroutine #22620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: daikin
cla-signed
integration: tellduslive
small-pr
ghost
added
the
|
According to @MartinHjelmare's comment #22417 (comment) |
|
Make sure you have no IO on initial process for them |
Co-Authored-By: fredrike <fredrik.e@gmail.com>
All of them are deprecated and are just there for backwards compatibilities ( I don't know how long they are supposed to be there though (both Daikin and Telldus Live are configured via the Config flow). |
|
Until the EntityPlatform helper is made to handle platforms without this function, we need to keep it around. |
MartinHjelmare
approved these changes
Apr 1, 2019
|
Can be merged when build passes. |
rohankapoorcom
approved these changes
Apr 1, 2019
unibeck
pushed a commit
to unibeck/home-assistant
that referenced
this pull request
Apr 7, 2019
* make setup_platform a coroutine * Update homeassistant/components/tellduslive/sensor.py Co-Authored-By: fredrike <fredrik.e@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make platform setup a coroutine.
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: