Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make platform setup a coroutine #22620

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented Apr 1, 2019

Description:

Make platform setup a coroutine.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fredrike
Copy link
Contributor Author

fredrike commented Apr 1, 2019

According to @MartinHjelmare's comment #22417 (comment)

@pvizeli
Copy link
Member

pvizeli commented Apr 1, 2019

Make sure you have no IO on initial process for them

Co-Authored-By: fredrike <fredrik.e@gmail.com>
@fredrike
Copy link
Contributor Author

fredrike commented Apr 1, 2019

Make sure you have no IO on initial process for them

All of them are deprecated and are just there for backwards compatibilities (pass).

I don't know how long they are supposed to be there though (both Daikin and Telldus Live are configured via the Config flow).

@MartinHjelmare
Copy link
Member

Until the EntityPlatform helper is made to handle platforms without this function, we need to keep it around.

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@rohankapoorcom rohankapoorcom merged commit 0056fcf into home-assistant:dev Apr 1, 2019
@ghost ghost removed the in progress label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants