Somfy open api #9625
Somfy open api #9625
Conversation
|
Please merge the |
klaasnicolaas
added
has-parent
frenck
added
parent-merged
There was a problem hiding this comment.
Hi @tetienne, could you please resolve the request by @klaasnicolaas? That allows us to merge this PR in and finish up the docs for 0.95
|
Sorry I didn't see your message @klaasnicolaas @frenck. Cover documentation has been merged. |
|
Thanks, @tetienne for that extreme quick response there! 🐎 I'll take a look in a second. |
tetienne
force-pushed
the
somfy-open-api
branch
2 times, most recently
from
3bcaad6 to
0af0849
Compare
|
You are welcome 😊 |
source/_components/somfy.markdown
Outdated
| - Hub | ||
| ha_iot_class: Cloud Polling | ||
| ha_release: 0.95 | ||
| ha_qa_scale: gold |
There was a problem hiding this comment.
The quality scale index is incorrect IMHO. For a gold standard, there should be tests between HA & the integration. Currently, I only see tests for the configuration flow. (which are excluded from the code coverage, which it should NOT have been btw...)
See: https://developers.home-assistant.io/docs/en/integration_quality_scale_index.html
For now, I suggest removing this.
There was a problem hiding this comment.
Are you talking about this:
Tests for reading data from/controlling the integration (docs)
What do you think to replace by Silver 🥈 ?
There was a problem hiding this comment.
For the coverage, I will see how include my tests.
There was a problem hiding this comment.
Well for silver it should:
✅ Connection/configuration is handled via a component.
❌ Set an appropriate SCAN_INTERVAL (if a polling integration)
❌ Raise PlatformNotReady if unable to connect during platform setup (if appropriate)
❓ Handles expiration of auth credentials. Refresh if possible or print correct error and fail setup.
❓ If based on a config entry, should trigger a new config entry flow to re-authorize.
❓ Handles internet unavailable. Log a warning once when unavailable, log once when reconnected.
❓ Handles device/service unavailable. Log a warning once when unavailable, log once when reconnected.
❌ Set available property to False if appropriate (docs)
✅ Entities have unique ID (if available) (docs)
Even though I haven't checked on the question marks, I still see missing things for a silver 🥈
There was a problem hiding this comment.
You are right. I will remove it. I have still a lot of stuff to do it seems.
Sadly, it seems that existing component with qa scale don't respect these rules. Do you know a good one?
There was a problem hiding this comment.
The QA scale should be correct in the documentation. If you feel like one is incorrect, feel free to raise an issue or open a PR.
Hue & deCONZ are probably good examples.
There was a problem hiding this comment.
Thank you for the information.
frenck
removed
in-progress
Description:
Pull request in home-assistant: home-assistant/core#19548
Checklist:
nextis for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created againstcurrent.