Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for camera_view #9290

Merged
merged 7 commits into from
Apr 24, 2019
Merged

Conversation

hunterjm
Copy link
Member

Description:

Adds documentation to show live camera view in Lovelace.

Pull request in home-assistant (if applicable): home-assistant/home-assistant-polymer/#3086

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@OverloadUT OverloadUT added the ready-for-review This PR needs to be reviewed label Apr 24, 2019
balloob
balloob previously approved these changes Apr 24, 2019
@balloob balloob added this to the 0.92.0 milestone Apr 24, 2019
@balloob balloob added the cherry-picked This PR has been manually picked and merged into the current branch label Apr 24, 2019
@@ -373,6 +373,10 @@ camera_image:
required: false
description: A camera entity.
type: string
camera_view:
required: false
description: '"live" will show the live view if `stream` is enabled. Default: auto.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pherhaps default: auto ?

@@ -30,6 +30,10 @@ camera_image:
required: false
description: "Camera `entity_id` to use. (not required if `entity` is already a camera-entity)."
type: string
camera_view:
required: false
description: '"live" will show the live view if `stream` is enabled. Default: auto.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -38,6 +38,10 @@ camera_image:
required: false
description: Camera entity as Background image.
type: string
camera_view:
required: false
description: '"live" will show the live view if `stream` is enabled. Default: auto.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@balloob
Copy link
Member

balloob commented Apr 24, 2019

damn it @klaasnicolaas , I am trying to ship this thing 😆

@balloob
Copy link
Member

balloob commented Apr 24, 2019

Fixed it.

@balloob balloob merged commit 8a08145 into home-assistant:next Apr 24, 2019
@balloob balloob removed the ready-for-review This PR needs to be reviewed label Apr 24, 2019
balloob pushed a commit that referenced this pull request Apr 24, 2019
* add documentation for camera_view

* Update picture-elements.markdown

* Update picture-entity.markdown

* Update picture-glance.markdown

* Update picture-elements.markdown

* Update picture-entity.markdown

* Update picture-glance.markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked This PR has been manually picked and merged into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants