-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify continuous mode is enabled by default in the Roomba integration #34237
Conversation
WalkthroughWalkthroughThe recent changes clarify the Roomba integration's connection behavior, specifically regarding the MQTT server and continuous mode. The previous warning suggested that enabling continuous mode would force cloud connectivity, but the update emphasizes that continuous mode is enabled by default. Users are now informed they can disable this mode in the configuration settings after adding the integration, enhancing clarity and user understanding of the default settings. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Roomba Integration
participant MQTT Server
participant Cloud
User->>Roomba Integration: Add Integration
Roomba Integration->>MQTT Server: Connect (Continuous Mode Enabled)
MQTT Server->>Cloud: Connect to Cloud
User->>Roomba Integration: Disable Continuous Mode
Roomba Integration->>MQTT Server: Update Configuration
MQTT Server->>Cloud: Disconnect
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @deviantintegral 👍
Proposed change
The Roomba integration defaults to enabling continuous mode, yet the docs say otherwise. This PR cleans that up!
Type of change
current
branch).current
branch).next
branch).next
branch).Checklist
current
branch.next
branch.Summary by CodeRabbit
Bug Fixes
Documentation