Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.8.1 #34236

Merged
merged 2 commits into from
Aug 10, 2024
Merged

2024.8.1 #34236

merged 2 commits into from
Aug 10, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Aug 10, 2024

Proposed change

For: home-assistant/core#123544

Summary by CodeRabbit

  • New Features

    • Introduced support for the v3 Coinbase API.
    • Added action YAML syntax support for older notify groups.
    • Established a structured patch release strategy focusing on weekly updates.
  • Bug Fixes

    • Resolved various integration issues, including those with Doorbird and Bluesound.
    • Adjusted properties for the transmission integration to enhance performance.
    • Fixed startup blockage caused by integration issues.
  • Improvements

    • Updated several libraries to ensure better performance and security.
    • Enhanced compatibility and functionality with the latest API updates.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 10, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link
Contributor

coderabbitai bot commented Aug 10, 2024

Walkthrough

Walkthrough

The recent updates include a minor version increment for Home Assistant, changing the current patch version from 0 to 1 with a new release date of August 10, 2024. A new markdown section on patch release strategies emphasizes a focus on bug fixes and a weekly release cadence. Significant enhancements, such as support for the v3 Coinbase API and several bug fixes, improve the overall functionality and stability of the application.

Changes

Files Change Summary
_config.yml Updated current_patch_version from 0 to 1 and date_released from 2024-08-07 to 2024-08-10.
source/_posts/2024-08-07-release-20248.markdown Added a "Patch releases" section detailing the release strategy and listing changes for patch release 2024.8.1.
source/changelogs/core-2024.8.markdown Added support for the v3 Coinbase API, updated multiple libraries, and fixed several bugs to enhance functionality and stability.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant APIs
    participant Libraries
    
    User->>HomeAssistant: Request features
    HomeAssistant->>APIs: Integrate v3 Coinbase API
    APIs-->>HomeAssistant: Provide data
    HomeAssistant->>Libraries: Update dependencies
    Libraries-->>HomeAssistant: New features and fixes
    HomeAssistant-->>User: Enhanced functionality and stability
Loading

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 06b7843 and d256428.

Files selected for processing (1)
  • source/_posts/2024-08-07-release-20248.markdown (2 hunks)
Additional context used
Markdownlint
source/_posts/2024-08-07-release-20248.markdown

660-660: Unused link or image reference definition: "#123276"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


682-682: Duplicate link or image reference definition: "@Bre77"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


685-685: Duplicate link or image reference definition: "@LouisChrist"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


688-688: Duplicate link or image reference definition: "@bdraco"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


689-689: Duplicate link or image reference definition: "@cnico"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


690-690: Duplicate link or image reference definition: "@dmulcahey"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


692-692: Duplicate link or image reference definition: "@emontnemery"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


694-694: Duplicate link or image reference definition: "@frenck"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


696-696: Duplicate link or image reference definition: "@joostlek"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


699-699: Duplicate link or image reference definition: "@mib1185"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


700-700: Duplicate link or image reference definition: "@noahhusby"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


701-701: Duplicate link or image reference definition: "@puddly"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

Additional comments not posted (3)
source/_posts/2024-08-07-release-20248.markdown (3)

626-630: LGTM!

The "Patch releases" section is well-written and clear.


632-656: LGTM!

The "2024.8.1 - August 10" section is informative and well-structured.


682-702: Remove duplicate link references.

There are several duplicate link reference definitions, which should be cleaned up to avoid redundancy.

Tools
Markdownlint

682-682: Duplicate link or image reference definition: "@Bre77"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


685-685: Duplicate link or image reference definition: "@LouisChrist"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


688-688: Duplicate link or image reference definition: "@bdraco"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


689-689: Duplicate link or image reference definition: "@cnico"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


690-690: Duplicate link or image reference definition: "@dmulcahey"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


692-692: Duplicate link or image reference definition: "@emontnemery"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


694-694: Duplicate link or image reference definition: "@frenck"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


696-696: Duplicate link or image reference definition: "@joostlek"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


699-699: Duplicate link or image reference definition: "@mib1185"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


700-700: Duplicate link or image reference definition: "@noahhusby"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


701-701: Duplicate link or image reference definition: "@puddly"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Aug 10, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit d256428
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66b79c694c578300080bf9fd
😎 Deploy Preview https://deploy-preview-34236--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range, codebase verification and nitpick comments (1)
source/_posts/2024-08-07-release-20248.markdown (1)

626-630: Clarify the patch release schedule.

The description of the patch release schedule could be more explicit about the start date and any exceptions to the weekly cadence.

Consider adding more details to enhance clarity.


[#116345]: https://github.com/home-assistant/core/pull/116345
[#120178]: https://github.com/home-assistant/core/pull/120178
[#123276]: https://github.com/home-assistant/core/pull/123276
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused link reference.

The link reference #123276 is defined but not used in the document. Consider removing it to clean up the markdown file.

- [#123276]: https://github.com/home-assistant/core/pull/123276
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[#123276]: https://github.com/home-assistant/core/pull/123276
Tools
Markdownlint

1205-1205: Unused link or image reference definition: "#123276"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

Comment on lines +682 to +702
[@Bre77]: https://github.com/Bre77
[@DCSBL]: https://github.com/DCSBL
[@JakeMartin-ICL]: https://github.com/JakeMartin-ICL
[@LouisChrist]: https://github.com/LouisChrist
[@SteveEasley]: https://github.com/SteveEasley
[@TomBrien]: https://github.com/TomBrien
[@bdraco]: https://github.com/bdraco
[@cnico]: https://github.com/cnico
[@dmulcahey]: https://github.com/dmulcahey
[@dupondje]: https://github.com/dupondje
[@emontnemery]: https://github.com/emontnemery
[@freekode]: https://github.com/freekode
[@frenck]: https://github.com/frenck
[@fustom]: https://github.com/fustom
[@joostlek]: https://github.com/joostlek
[@matrixd2]: https://github.com/matrixd2
[@mattyway]: https://github.com/mattyway
[@mib1185]: https://github.com/mib1185
[@noahhusby]: https://github.com/noahhusby
[@puddly]: https://github.com/puddly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate link references.

There are several duplicate link reference definitions, which should be cleaned up to avoid redundancy.

- [@Bre77]: https://github.com/Bre77
- [@LouisChrist]: https://github.com/LouisChrist
- [@bdraco]: https://github.com/bdraco
- [@cnico]: https://github.com/cnico
- [@dmulcahey]: https://github.com/dmulcahey
- [@emontnemery]: https://github.com/emontnemery
- [@frenck]: https://github.com/frenck
- [@joostlek]: https://github.com/joostlek
- [@mib1185]: https://github.com/mib1185
- [@noahhusby]: https://github.com/noahhusby
- [@puddly]: https://github.com/puddly

Committable suggestion was skipped due to low confidence.

Tools
Markdownlint

682-682: Duplicate link or image reference definition: "@Bre77"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


685-685: Duplicate link or image reference definition: "@LouisChrist"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


688-688: Duplicate link or image reference definition: "@bdraco"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


689-689: Duplicate link or image reference definition: "@cnico"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


690-690: Duplicate link or image reference definition: "@dmulcahey"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


692-692: Duplicate link or image reference definition: "@emontnemery"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


694-694: Duplicate link or image reference definition: "@frenck"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


696-696: Duplicate link or image reference definition: "@joostlek"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


699-699: Duplicate link or image reference definition: "@mib1185"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


700-700: Duplicate link or image reference definition: "@noahhusby"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)


701-701: Duplicate link or image reference definition: "@puddly"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

joostlek
joostlek previously approved these changes Aug 10, 2024
Co-authored-by: TheJulianJES <TheJulianJES@users.noreply.github.com>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


[#116345]: https://github.com/home-assistant/core/pull/116345
[#120178]: https://github.com/home-assistant/core/pull/120178
[#123276]: https://github.com/home-assistant/core/pull/123276
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused link reference.

The link reference #123276 is defined but not used in the document.

- [#123276]: https://github.com/home-assistant/core/pull/123276
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[#123276]: https://github.com/home-assistant/core/pull/123276
Tools
Markdownlint

660-660: Unused link or image reference definition: "#123276"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

@frenck frenck merged commit 01c64f4 into current Aug 10, 2024
8 checks passed
@frenck frenck deleted the frenck-2024-0484 branch August 10, 2024 17:33
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Aug 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants