-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation YAML example in androidtv_remote #34228
Conversation
Changes from 'service' to 'action' created an invalid .yaml in this example.
WalkthroughWalkthroughThe recent changes streamline the action handling for remote control buttons in the Android TV integration. The action type has transitioned from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant ActionHandler
participant RemoteService
User->>UI: Tap Button
UI->>ActionHandler: Trigger tap_action
ActionHandler->>RemoteService: perform-action(remote.send_command)
RemoteService-->>ActionHandler: Acknowledge command
ActionHandler-->>UI: Update UI state
sequenceDiagram
participant User
participant UI
participant ActionHandler
participant RemoteService
User->>UI: Long Press Button
UI->>ActionHandler: Trigger hold_action
ActionHandler->>RemoteService: perform-action(remote.send_command)
RemoteService-->>ActionHandler: Acknowledge command
ActionHandler-->>UI: Update UI state
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dudau16 👍
../Frenck
Proposed change
duplicated mapping key ... action:
)Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
tap_action
andhold_action
to maintain functionality while aligning with the new action structure.