-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config flow to compensation helper #33723
base: next
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughThe Compensation integration has been enhanced to incorporate a Changes
Sequence DiagramssequenceDiagram
participant User
participant HA_System
participant Compensation_Integration
User->>HA_System: Access Home Assistant
HA_System->>Compensation_Integration: Load Integration
Compensation_Integration->>HA_System: Provide ha_config_flow
HA_System->>User: Display Configuration Options
User->>HA_System: Configure Integration (via UI/YAML)
HA_System->>Compensation_Integration: Apply Configuration
Compensation_Integration->>HA_System: Integration Configured as Helper
HA_System-->User: Integration Ready
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Degree: | ||
description: "The degree of a polynomial. For example, Linear compensation (y = x + 3) has 1 degree, Quadratic compensation (y = x<sup>2</sup> + x + 3) has 2 degrees, etc." | ||
Precision: | ||
description: Defines the precision of the calculated values, through the argument of round(). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example for this one, maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am rewriting it to make it less complicated so even without an example it should be understandable I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @gjohansson-ST 👍
Proposed change
Adds config flow to
compensation
helperType of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
ha_config_flow
attribute.ha_integration_type
from "integration" to "helper" for the Compensation integration.