Nav fixes #908
Merged
Nav fixes #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
balloob
commented
Feb 21, 2018
balloob
commented
- Show error message if user tries to edit a script that is not editable.
- Fix being able to navigate. The error fallback broke, but only in compiled build
balloob
commented
Feb 21, 2018
| @@ -1,7 +1,6 @@ | |||
| <link rel="import" href='../../bower_components/polymer/polymer-element.html'> | |||
| <link rel='import' href='../../bower_components/iron-media-query/iron-media-query.html'> | |||
| <link rel='import' href='../../bower_components/app-route/app-route.html'> | |||
| <link rel="import" href="../../bower_components/iron-pages/iron-pages.html"> | |||
There was a problem hiding this comment.
Realized that if we wrap everything in an if, we don't need iron-pages
|
I'm going to merge this because |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.