-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for percentage step size to fans #8393
Conversation
Not having the pin feels a bit inconsistent since I think we have it in most (?) other sliders. Couldn't we just round the pin value? |
Any idea how to do that? I couldn't find a way that worked with the underlying api |
@spacegaier @bdraco maybe do it the other way: |
While I think that will solve the pin issue, we would still need to translate the speed number back into a percentage so we still get a float, but at least we could hide it. If the fan doesn't have a fixed step (100 speeds) aka variable rate fan they would get 1-100 still. The downside is we loose a bit of the abstraction. |
ee2c0ed
to
f3562ff
Compare
I came up with a solution to avoid the need to hide the pin. |
Proposed change
Add support for percentage step size to fans
The pin value is now rounded to prevent floating points from showing up in the UI.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: