Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to codemirror 6 #8382

Merged
merged 9 commits into from
Feb 24, 2021
Merged

Migrate to codemirror 6 #8382

merged 9 commits into from
Feb 24, 2021

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented Feb 12, 2021

Proposed change

Mostly works, things to do:

  • ctrl/cmd+s handling
  • fix comments checks
  • migrate edited checks in hui-editor
  • rtl
  • lazy loading
  • clean up

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten marked this pull request as ready for review February 24, 2021 15:47
@bramkragten bramkragten changed the title WIP: Migrate to codemirror 6 Migrate to codemirror 6 Feb 24, 2021
@bramkragten bramkragten requested a review from ludeeus February 24, 2021 15:47
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/panels/lovelace/hui-editor.ts Outdated Show resolved Hide resolved
@bramkragten bramkragten merged commit bde925a into dev Feb 24, 2021
@bramkragten bramkragten deleted the codemirror-6 branch February 24, 2021 18:16
@bramkragten bramkragten mentioned this pull request Feb 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants