Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excessive rerendering of history charts #8340

Merged
merged 6 commits into from
Feb 24, 2021

Conversation

larena1
Copy link
Contributor

@larena1 larena1 commented Feb 6, 2021

Breaking change

Proposed change

Closes #8274

When @spacegaier reimplemented the history chart as LitElement, that unfortunately broke their tooltips because the chart would rerender on every change of the hass object. In my case that was every 500 ms and I'm not able to read that fast.

This PR implements shouldUpdate so the chart only rerenders when there was either a change to its own entity or the underlying history data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@homeassistant
Copy link
Contributor

Hi @larena1,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bramkragten bramkragten merged commit 0f574a7 into home-assistant:dev Feb 24, 2021
@bramkragten bramkragten mentioned this pull request Feb 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart tooltips hidden immediately
3 participants