Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow fix #23652

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Overflow fix #23652

merged 3 commits into from
Jan 15, 2025

Conversation

yosilevy
Copy link
Contributor

@yosilevy yosilevy commented Jan 9, 2025

Breaking change

Proposed change

Fixes overflow problems in RTL

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yosilevy,

when there is no graph you hide the date selection:

image

@home-assistant home-assistant bot marked this pull request as draft January 9, 2025 10:35
@home-assistant
Copy link

home-assistant bot commented Jan 9, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@yosilevy
Copy link
Contributor Author

@wendevlin Thanks for finding this. Fixed.

@yosilevy yosilevy marked this pull request as ready for review January 12, 2025 10:57
@home-assistant home-assistant bot requested a review from wendevlin January 12, 2025 10:57
@wendevlin
Copy link
Contributor

@yosilevy thank you,

But there is still an issue on mobile, when calendar controls are higher then the screen.

Can you maybe specify the bug you try to solve in more details? With a video or screenshot where the issue is.

@bramkragten
Copy link
Member

Set the overflow on a higher element, like in ha-top-app-bar-fixed

@yosilevy
Copy link
Contributor Author

@bramkragten thanks. Done with some modifications which make it work.
@wendevlin thanks for the catch. I checked this one inside web debugger for mobile and web and it seems OK. I hope you'll see same. Thanks.

Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@wendevlin wendevlin merged commit 52d8e98 into home-assistant:dev Jan 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants