Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of Suspend connection option #23470

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

NoRi2909
Copy link
Contributor

When the suspend option in the user profile is enabled the browser connection is dropped after a tab or window remains in the background for five minutes. Bringing it back to the front will cause it to reconnect, meaning that the window content will take a while to refresh all entities shown.

image

The current wording is easy to misread, so a previous German translation turned this into "hiding the connection" which made no sense at all.

Proposed change

This PR changes the two strings to:

Suspend background connections
For hidden windows or background tabs close the server connection after 5 minutes.

This moves the main purpose into the headline, making it easier to further explain in the description below.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

This removes the use of "we" which is kind of off as no person is involved in the process.

It also moves the word "suspend" in the headline and better explains the purpose.
Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that "suspend" is better than "close" as the connection is eventually restored

@MindFreeze MindFreeze enabled auto-merge (squash) December 27, 2024 11:20
@MindFreeze MindFreeze merged commit 918aa56 into home-assistant:dev Dec 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear description of suspend option for server connection
2 participants