-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine Edit in yaml and Edit in visual editor (1/2) #23142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendevlin
requested changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
Found just some small improvements, please repeat them in the other files too.
src/panels/config/automation/action/ha-automation-action-row.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/action/ha-automation-action-row.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/action/ha-automation-action-row.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/condition/ha-automation-condition-row.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/condition/ha-automation-condition-row.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/condition/ha-automation-condition-row.ts
Outdated
Show resolved
Hide resolved
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
wendevlin
approved these changes
Dec 11, 2024
boern99
pushed a commit
to boern99/ha_frontend
that referenced
this pull request
Dec 11, 2024
…23142) * yaml / visual part 1 * clean up * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Combines the "Edit in yaml" and "Edit in visual editor" list items similar to other experiences.
When in visual editor, it will show "edit in yaml" and the other way around. Part 1 is for automation area.
Fixes #19172
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: