-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple: true
for expandable sections
#22965
base: dev
Are you sure you want to change the base?
Conversation
multiple: true
for expandable sections
Should we create dedicated selector for that instead of reusing the expandable one? I already attempted something like that but without success. So we can add/edit/delete/reorder. Also, we should be able to define the title of each group (by using one of the nested field value?) because for now, we have the same title (data point) for each section. |
Is the issue here that you specifically want this to be a Selector instead of a form element, or is the issue just that I've overloaded this form element with too much optional code (and to call it a different form element name/.ts file)? I'm a little puzzled how to make this into a Selector, given that it's really just an empty container for other Selectors. I'm not quite sure what change that would look like on both the backend and frontend side, but this current implementation felt kind of natural to me since it felt very similar to the concept we already invented for sections.
What is the intention of the pencil button, we are already in a options dialog here, does that open a new popup dialog over the existing popup dialog? I kind of liked having everything viewable at once, but that's just my personal opinion.
I guess reorder handles could be added to any UI, not sure if that is needed in this iteration though?
I guess if we had a child selector with the magic name |
@karwosts we're reviewing solutions. I'll get back to you at the start of the next week. |
@karwosts Sharing you the design. We opted for a list-item style component that resembles the current . https://www.figma.com/design/aJJlYSKScPmTzaLDzsM37I/HA-19?node-id=0-1&t=xvuj9WWvCQfdJTIX-1 |
Proposed change
Allow setting
multiple: true
for an expandable section, which would mean that that section now behaves like a group of selectors, with user allowed to submit multiple copies of the data requested by the section.Backend PR: home-assistant/core#131393
Based on a concept idea by Frenck: home-assistant/core#121857 (comment)
Example: entering datapoint pairs, where the user can submit a list, and each list item is two numbers:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: