Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scene Editor #22847

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Update Scene Editor #22847

merged 4 commits into from
Nov 20, 2024

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Nov 16, 2024

Proposed change

Updates to scene editor as proposed: https://www.figma.com/design/TJ1yBZUyOWQtLmugi239BU/HA-12?node-id=0-1&node-type=canvas

Continuation from #20094

Extra help testing would be appreciated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

This comment was marked as off-topic.

@karwosts karwosts mentioned this pull request Nov 16, 2024
9 tasks
@piitaya piitaya added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Nov 19, 2024
Copy link
Contributor

@wendevlin wendevlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karwosts 🎉 This improves the UX a lot.

I have some desing improvements in mind, which I will add in another PR.

  • live / review mode toggle on mobile must become smaller
  • Improve spacing
  • Instead of empty devices/entities show some info
  • Deduplicate entities heading.

@wendevlin wendevlin merged commit 37d2c68 into home-assistant:dev Nov 20, 2024
16 checks passed
@karwosts karwosts deleted the new-scenes-v2 branch November 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants