-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added hold and double tap actions for tile card icon #21947
Added hold and double tap actions for tile card icon #21947
Conversation
WalkthroughWalkthroughThe changes introduce new interaction capabilities to the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂
We didn't add the feature because it's a pretty hidden feature but for flexibility I agree that we can have it as yaml
only feature 🙂
Proposed change
Added icon_hold_action and icon_double_tap_action for the Tile card.
The hold and double tap actions option has been introduced in PR #18345. But the hold or double tap icon is not supported. And a hold tap on an icon invokes icon_action not hold_action.
This is probably a bug because tap was used in any action.
frontend/src/panels/lovelace/cards/hui-tile-card.ts
Line 140 in b48a28f
This pr will allow the user to apply the same hold action to the content and the icon.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit
These updates improve user engagement by enabling more nuanced control over tile card responses to gestures.