Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify script/automation action description with nested conditions/triggers #17252

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jul 10, 2023

Proposed change

Do not include nested condition and action description in the parent description.
The change has been made for :

  • if
  • repeat
  • wait_for_trigger

Before

CleanShot 2023-07-10 at 11 45 10

After

CleanShot 2023-07-10 at 11 45 34

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@piitaya piitaya changed the title Simplify if else and repeat script/automation description Simplify script/automation action description with nested conditions/triggers Jul 10, 2023
@piitaya piitaya marked this pull request as draft July 10, 2023 09:56
@piitaya piitaya marked this pull request as ready for review July 10, 2023 10:05
@piitaya piitaya merged commit 228b75a into dev Jul 10, 2023
@piitaya piitaya deleted the simplify_if_else branch July 10, 2023 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants