-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit YAML still broken on iOS with code mirror 6 (copy, paste, replace issues) #8542
Comments
If you see the exact same behavior as with the previous version, and the demo of codemirror 6 works, I would say your cache is not cleared correctly? |
I deleted "All Website Data" as written, as I hoped to be able to preserve my history data. So I think the cache should not be the issue. |
I’m seeing the same issue on iOS. Used ‘Reset Frontend Cache’ within home assistant app and still unable to select, copy, paste consistently where as the Codemirror 6 demo (https://codemirror.net/6/) works perfectly. |
Issues still present in 2021.3.1. Also in latest version a horizontal white selection is seen before selecting anything which isn’t an issue in non dark mode themes but light themes obscure the selection text. EDIT: I see the active line issue in dark mode is now fixed: #8556 |
I've just seen, that you implemented codemirror/view release 0.18.0 and I only guessed it was codemirror/codemirror.next, as "better mobile support" was mentioned. As the current codemirror 5 version isn't working fine on mobile I guess we'll wait for codemirror.next to be in a stable state and integrated in home assistant for this to be fixed. |
We do use codemirror/next |
I have the same issue on iOS (MobileApp, Mobile Safari, Mobile Chrome) and it is always reproducible. Can paste only on top of edit area no matter where cursor is. Can't delete any symbol at any position, only when I select something and write a letter it replaces the selection and after that cursor is immediately moving at top left position. Now the yaml editor is fully unusable in IOS :( I've checked Codemirror 6 demo too and it is works fine. |
I updated the upstream issue with a repo. |
Checklist
Describe the issue you are experiencing
Copy and paste still has some issues with code mirror 6 on iOS (tested in safari & Home Assistant App).
Issues in Script Editor > Actions > Edit in Yaml:
-- Pasting it pasts the whole line
YAML Editors on Lovelace cards have the same issues as with code mirror 5.
Deleted "all website data" in Settings > Safari > Website Data (Did not delete my whole history).
Describe the behavior you expected
Boeing able to copy, paste and replace like the demo on www.codemirror.net/6
Steps to reproduce the issue
...
What version of Home Assistant Core has the issue?
2021.3.0
What was the last working version of Home Assistant Core?
In which browser are you experiencing the issue with?
iOS 14.4 Safari
Which operating system are you using to run this browser?
iOS 14.4
State of relevant entities
# Paste your state here.
Problem-relevant frontend configuration
# Paste your YAML here.
Javascript errors shown in your browser console/inspector
# Paste your logs here.
Issue #8534 should have been fixed by pull request #8382
The text was updated successfully, but these errors were encountered: