-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pydaikin to 2.10.1 #94214
Bump pydaikin to 2.10.1 #94214
Conversation
Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@fredrike I am getting AttributeError: module 'collections' has no attribute 'MutableMapping' when the integration starts. I have fixed it by importing 'MutableMapping' from 'collections.abc' https://bitbucket.org/mustang51/pydaikin/pull-requests/64 |
Hello, I have 2x a Daikin Airco. |
@fredrike Could you release another build? |
Well, your last pr didn't build with pre-commit (pylint issues) https://bitbucket.org/mustang51/pydaikin/pipelines/results/181 so as soon you have fixed that. I suggest that we revert pydaikin to last version as there were so many issues with 2.10.. |
There is a version 2.10.2 on pypi now.. |
Thanks for fixing the linting issue. |
@fredrike I can revert to 2.9.0 while we fix the bugs |
@mover85 don't do Merge with upstream branch, do a rebase instead.. https://developers.home-assistant.io/docs/development_catching_up The 2.10.3 version of pydaikin fixes #94372 too. |
64adf04
to
d811fa0
Compare
Proposed change
Bump Daikin version, changelog: https://bitbucket.org/mustang51/pydaikin/branches/compare/v2.10.1%0Dv2.9.1
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: