Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.1+ #93013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently a relatively fast memory leak when using cpython 3.11.2+ and cleanup_closed with aiohttp For my production instance it was leaking ~450MiB per day of `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport` `memoryview`, and `managedbuffer` objects see aio-libs/aiohttp#7252 see python/cpython#98540
home-assistant
bot
added
bugfix
cla-signed
core
small-pr
bdraco
changed the title
bdraco
added a commit
that referenced
this pull request
May 13, 2023
related issue aio-libs/aiohttp#7252 related PR #93013
bdraco
commented
May 13, 2023
20 tasks
balloob
approved these changes
May 14, 2023
balloob
pushed a commit
that referenced
this pull request
May 14, 2023
…93013) * Disable cleanup_closed for aiohttp.TCPConnector with cpython 3.11.2+ There is currently a relatively fast memory leak when using cpython 3.11.2+ and cleanup_closed with aiohttp For my production instance it was leaking ~450MiB per day of `MemoryBIO`, `SSLProtocol`, `SSLObject`, `_SSLProtocolTransport` `memoryview`, and `managedbuffer` objects see aio-libs/aiohttp#7252 see python/cpython#98540 * Update homeassistant/helpers/aiohttp_client.py
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
There is currently a relatively fast memory leak when using cpython 3.11.1+ and cleanup_closed with aiohttp
For my production instance it was leaking ~450MiB per day of
MemoryBIO,SSLProtocol,SSLObject,_SSLProtocolTransportmemoryview, andmanagedbufferobjectssee aio-libs/aiohttp#7252 see python/cpython#98540
We should be able to replace this with aio-libs/aiohttp#7280 in the future once 3.8.5 is released but that's months away at this point aio-libs/aiohttp#7252 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: