Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor.envirophat: add missing requirement #7451

Merged
merged 1 commit into from
May 5, 2017

Conversation

imrehg
Copy link
Contributor

@imrehg imrehg commented May 5, 2017

Description:

Adding a requirement that is for some reason not explicitly pulled in by the library that manages the Enviro pHAT.

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

Adding requirements that is not explicitly pulled in by the library
that manages the Enviro pHAT.
@mention-bot
Copy link

@imrehg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @rmkraus to be potential reviewers.

@balloob
Copy link
Member

balloob commented May 5, 2017

Make sure to file a bug report with the original package author so they fix their setup.py

@balloob balloob added this to the 0.44 milestone May 5, 2017
@balloob balloob merged commit 4b5be75 into home-assistant:dev May 5, 2017
balloob pushed a commit that referenced this pull request May 6, 2017
Adding requirements that is not explicitly pulled in by the library
that manages the Enviro pHAT.
This was referenced May 6, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants