Address Crownstone review comments #56485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert property addition, as we would otherwise have to add extra cast statements for every usage of the property. This way the type check knows exactly what type it is.
* These entries shall be added as binary sensors later.
* Use CrownstoneNotFoundError instead of generic KeyError
* Created base class for a Crownstone flow, which has methods used by both config and options flow * Fix step id's * Update tests to set up the integration before starting options flow; This includes a small change to write to hass.data in async_setup_entry, and not in entry_manager.async setup. This avoids having mock all the code in entry_manager.async_setup and we can just mock CrownstoneEntryManager entirely.
|
Hey there @crownstone, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
added
the
smash
* Use fixtures for other frequently used patches, and decorate with pytest.mark.usefixtures.
* Test if the integration setup was called in every config flow test. * Use a type alias for fixtures to provide more clarity of what these parameters are.
|
Thanks Martin, all fixtures yield their mock now and are tested on call count in the tests where they are used. I'm slowly getting more familiar with the pytest toolkit :) |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Address the extra review comments by @MartinHjelmare in #50677
I have not found a good way to deal with the use of persistent notification in
entry_manager.py, line 143. After testing i'm sure that triggering a new flow is not a good idea here. Especially not without any context (notification) why it was triggered.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: