Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flow to OpenEVSE component #55303

Closed
wants to merge 18 commits into from

Conversation

firstof9
Copy link
Contributor

@firstof9 firstof9 commented Aug 26, 2021

Proposed change

Add config flow to OpenEVSE component and allow username and password authentication.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Contributor

@milanmeu milanmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% coverage is required for the config_flow.

Line 152 was not covered by tests:
https://github.com/home-assistant/core/pull/55303/checks?check_run_id=3445045908

homeassistant/components/openevse/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/openevse/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/openevse/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/openevse/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/openevse/const.py Outdated Show resolved Hide resolved
homeassistant/components/openevse/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/openevse/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/openevse/sensor.py Outdated Show resolved Hide resolved
Copy link
Contributor

@milanmeu milanmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test the strings.json changes with:

python3 -m script.translations develop

You can add the generated translations/en.json to the PR.

homeassistant/components/openevse/strings.json Outdated Show resolved Hide resolved
homeassistant/components/openevse/strings.json Outdated Show resolved Hide resolved
@firstof9
Copy link
Contributor Author

Thank you for your helpful reviews.

@firstof9
Copy link
Contributor Author

firstof9 commented Sep 3, 2021

@milanmeu any more suggestions or is this looking good now?

@drobtravels
Copy link
Contributor

Any steps remaining in this PR? I just got installed OpenEVSE and was looking at improving the integration. Happy to help out.

@firstof9
Copy link
Contributor Author

Seems the PR's stalled out, I've been tinkering on a custom integration now.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 29, 2022
@firstof9 firstof9 closed this Jan 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants