-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config flow to OpenEVSE component #55303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% coverage is required for the config_flow.
Line 152 was not covered by tests:
https://github.com/home-assistant/core/pull/55303/checks?check_run_id=3445045908
aad4607
to
d8cc674
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test the strings.json
changes with:
python3 -m script.translations develop
You can add the generated translations/en.json
to the PR.
Thank you for your helpful reviews. |
@milanmeu any more suggestions or is this looking good now? |
Any steps remaining in this PR? I just got installed OpenEVSE and was looking at improving the integration. Happy to help out. |
Seems the PR's stalled out, I've been tinkering on a custom integration now. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Add config flow to OpenEVSE component and allow username and password authentication.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: