Homematic update with HomematicIP/HomematicWired support and multible… #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen, @danielperna84 and @fabaff to be potential reviewers. |
pvizeli
changed the title
houndci-bot
reviewed
Nov 28, 2016
| hmdevice.actionNodeData(param, 1, channel) | ||
| for _, devices in hass.data[DATA_HOMEMATIC].devices.items(): | ||
| if address in devices: | ||
| hmdevice = devices[address] |
There was a problem hiding this comment.
local variable 'hmdevice' is assigned to but never used
danielperna84
approved these changes
Nov 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR add support for multiple RPC servers to support homematic wireless, IP and wired at the same time. It is very costumizable and supports all feature on every connection. We also support reconnecting via service now in case the CCU/Homegear gets restarted. Usage of global variables is now removed and
hass.datais being used instead.That is the official start for Homematic IP and Homematic wired!
… connections