Fix RM mini 3 update manager #40215
Merged
Fix RM mini 3 update manager #40215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
integration: broadlink
small-pr
|
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with an integration ( |
|
@balloob I made a mini patch for RM mini 3, so users don't need to wait for the library. |
felipediel
commented
Sep 18, 2020
Comment on lines
+24
to
+25
| if device.api.model.startswith("RM mini"): | ||
| return BroadlinkRMMini3UpdateManager(device) |
There was a problem hiding this comment.
This will do the trick for now, but we should consider segregating interfaces at the library in the future.
felipediel
force-pushed
the
mini-patch
branch
from
cf74f24 to
79b3ee0
Compare
This was referenced Sep 18, 2020
balloob
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Create a separate class to manage RM mini 3 updates correctly. These devices do not have sensors. If we check_sensors() for RM mini 3 (0x5f36) we get a StorageError(). So we are gonna say hello to check if the device is online.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: