Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bond integration to be completely async #38066

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

prystupa
Copy link
Contributor

Proposed change

This is a refactoring to make bond integration completely async

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@marciogranzotto
Copy link
Contributor

Removing the bond-home dependency and moving to bond-api, you lose several things that are already working on that lib, for instance, brightness support for lights

@prystupa
Copy link
Contributor Author

prystupa commented Jul 22, 2020

Removing the bond-home dependency and moving to bond-api, you lose several things that are already working on that lib, for instance, brightness support for lights

thanks, @marciogranzotto - bond-api can execute arbitrary Bond action, including brightness support, like bond.action('device-id', Action("SetBrightness", 50))

@ctalkington ctalkington merged commit 3480fb6 into home-assistant:dev Jul 23, 2020
@prystupa prystupa deleted the bond-async branch July 23, 2020 01:25
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

homeassistant/components/bond/__init__.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants