Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle netatmo climate timeouts gracefully #24752

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

cgtobi
Copy link
Contributor

@cgtobi cgtobi commented Jun 25, 2019

Description:

Handle timeouts gracefully.

Related issue (if applicable): fixes #24751

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cgtobi cgtobi changed the title Handle timeouts gracefully Handle netatmo climate timeouts gracefully Jun 25, 2019
@cgtobi cgtobi requested a review from Danielhiversen June 25, 2019 10:49
@balloob balloob merged commit da57f92 into home-assistant:dev Jun 25, 2019
@balloob balloob added this to the 0.95.0 milestone Jun 25, 2019
@cgtobi cgtobi deleted the netatmo_climate_issue_24751 branch June 25, 2019 19:40
balloob pushed a commit that referenced this pull request Jun 26, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netatmo still with stability issue in 0.95.0b3
3 participants